switch to rusty-kaspa protos#6
Open
Leon1777 wants to merge 2 commits intokaspanet:mainfrom
Open
Conversation
Leon1777
commented
Feb 10, 2026
| Payload::GetInfoResponse(info) => info!("Kaspad version: {}", info.server_version), | ||
| Payload::NotifyNewBlockTemplateResponse(res) => match res.error { | ||
| ResponsePayload::GetInfoResponse(info) => { | ||
| info!("Kaspad: {} Synced: {}", info.server_version, info.is_synced) |
Author
There was a problem hiding this comment.
now also reports info.is_synced which can be used to pause the miner if the node becomes out of sync, afaik currently the miner will just report a warning but not pause
Leon1777
commented
Feb 10, 2026
| fn test_serialize_header() { | ||
| let header = RpcBlockHeader { | ||
| version: 24565, | ||
| hash: "0000000000000000000000000000000000000000000000000000000000000000".into(), |
Author
There was a problem hiding this comment.
not sure about the correctness here, it's ok for the test to pass and the compiler not to complain
Leon1777
commented
Feb 10, 2026
| --mine-when-not-synced Mine even when kaspad says it is not synced, only useful when passing `--allow-submit- | ||
| block-when-not-synced` to kaspad [default: false] | ||
| --mine-when-not-synced Mine even when kaspad says it is not synced, only useful when passing | ||
| `--enable-unsynced-mining` to kaspad [default: false] |
Author
There was a problem hiding this comment.
--allow-block-when-not-synced was the correct parameter for go-kaspad, it's changed in rk to --enable-unsynced-mining
Collaborator
|
Hello, could you please add a quick description of the change and the motivations? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migration makes it easier to keep grpc-protos in sync with rusty-kaspa going forward.
I used the latest protos from the tn12 branch here: https://github.com/kaspanet/rusty-kaspa/tree/tn12/rpc/grpc/core/proto