Feat: Unify AccessMetadata, add zero-copy decode, lock sort invariant#41
Merged
hmoog merged 2 commits intofeat/zk-convenantsfrom May 7, 2026
Merged
Feat: Unify AccessMetadata, add zero-copy decode, lock sort invariant#41hmoog merged 2 commits intofeat/zk-convenantsfrom
hmoog merged 2 commits intofeat/zk-convenantsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A malicious or buggy L1 transaction producer could declare duplicate resource_ids in its access metadata. The parent branch didn't dedup anywhere - neither the worker's extract_resources nor the guest's Payload::decode checked. This let two issues through:
Additionally, AccessMetadata was two structurally-identical types maintained in parallel - host-owned (vprogs_core_types::AccessMetadata) and guest-borrowed (vprogs_zk_abi::transaction_processor::AccessMetadata<'a>). The guest's Payload::decode allocated a Vec per parse, decoding entries one at a time.
Changes
Single shared AccessMetadata
Wire format invariant + dedup
Guest-side simplifications
Worker / scheduler integration
Cleanup