git-cache: consider if git_cache dir is present#3
Open
cgundogan wants to merge 1 commit intokaspar030:masterfrom
Open
git-cache: consider if git_cache dir is present#3cgundogan wants to merge 1 commit intokaspar030:masterfrom
cgundogan wants to merge 1 commit intokaspar030:masterfrom
Conversation
kaspar030
requested changes
Jan 6, 2017
| git clone --reference "${GIT_CACHE_DIR}" "${GIT_CACHE_DIR}" "${TARGET_PATH}" --branch commit$SHA1 | ||
| else | ||
| git clone --reference "${GIT_CACHE_DIR}" "${REMOTE}" "${TARGET_PATH}" | ||
| git clone "${REMOTE}" "${TARGET_PATH}" |
Owner
There was a problem hiding this comment.
This changes the semantic significantly. Before, it would use the .gitcache as reference also if the exact commit would not be in the cache. Now it ignores the cache in that case.
I think there should be another test if the cache dir exists and only if it doesn't do a checkout without reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adopted from RIOT-OS/RIOT/pull/6289