Conversation
- Enforced a 2MB decompression limit per bzip2 block to prevent resource exhaustion attacks. - Added a check to ensure input and output file paths are distinct using `std::fs::canonicalize`. - This prevents a SIGBUS error caused by truncating a memory-mapped input file. - Added `DecompressionLimitExceeded` error variant to `Bz2Error`. - Updated both the library and CLI tool to use these security enhancements. Co-authored-by: kassoulet <1905+kassoulet@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses two security and stability issues:
SIGBUScrash. We now verify they are distinct using canonicalized paths.PR created automatically by Jules for task 14830086709159860439 started by @kassoulet