Handling DistributionNotFound exceptions#60
Handling DistributionNotFound exceptions#60sezanzeb wants to merge 285 commits intokassoulet:mainfrom
Conversation
… into better_cli
Code Cleaning and Invalid Audiofiles Handling
Threaded batch mode
Fixed disc number interpretation Closes lp:1819223
lp:1819223
Closes lp:1851147, thanks phil995511
The basefolder is not quoted as it should be. If the converted file is within a subdirectory containing for example a # sign, soundconverter would hang.
Externalize TargetNameGenerator.safe_name()
fallback for get_tags, tests for audiofiles without tags
This is needed because gstreamer 1.19.2 does not add tags to the root anymore, they are only present at stream level.
Closes lp:1948670, thank Richard.
Not treating images as audio
Optimized filelist progress updates
Using GLib events instead of callbacks, fixed recursion problems
…line-option Support deleting original files when converting from CLI
sezanzeb
changed the title
sezanzeb
force-pushed
the
flatpak-fix-pkg_resources
branch
from
1bce184 to
23bfad6
Compare
|
@sezanzeb Thanks for looking into this! A flatpak built from this PR's ref launches normally again, but it shows $ flatpak run --user org.soundconverter.SoundConverter//master
ERROR: Disabling mp3-id-tags output. Do you have "gst-plugins-good" installed?
ERROR: Disabling mp3-vbr-tags output. Do you have "gst-plugins-ugly" installed?
soundconverter unknown-versionand in the GUI:
Is it possible to specify the version at build time? |
|
"unknown-version" is the fallback for this case
Yes, input-remapper does something similar with the commit hash: https://github.com/sezanzeb/input-remapper/blob/main/setup.py#L34, it writes it into a python file which is then imported during runtime. Instead of asking Or we hardcode the version number. It is hardcoded in setup.py already anyway. We just shouldn't forget to change it everywhere. |
|
I have no preference if you hardcode the version number or if I have to set it during packaging, but I'd prefer to have something else than "unknown version" showing up. |
This should not be necessary, but until someone can tell me what is going on here, at least this starts soundconverter again. Revisit after kassoulet/soundconverter#60 has been merged with a way to set a proper version number. Fixes flathub#6
|
I hope I'll find time to do this at some point, there are a lot of other things open in other projects right now |
10 participants
@jmaibaum does this work for you? Is the
os.environ.get('container') == 'flatpak'test reliable?