Skip to content

init supresses DeploymentConfiguration.Alarms if CodeDeploy #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fujiwara wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

init supresses DeploymentConfiguration.Alarms if CodeDeploy #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ecspresso.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,15 @@ func (d *App) newServiceFromTypes(ctx context.Context, in types.Service) (*Servi
return aws.ToString(dp.Status) == "PRIMARY"
})
if sv.isCodeDeploy() {
// CodeDeploy does not support ServiceConnectConfiguration and VolumeConfigurations
// CodeDeploy does not support
// - ServiceConnectConfiguration
// - VolumeConfigurations
// - DeploymentConfiguration.Alarms
sv.ServiceConnectConfiguration = nil
sv.VolumeConfigurations = nil
if sv.DeploymentConfiguration != nil {
sv.DeploymentConfiguration.Alarms = nil
}
return &sv, nil
}
if len(dps) == 0 {
Expand Down