Open
Conversation
hystking
approved these changes
Jan 18, 2018
hystking
left a comment
There was a problem hiding this comment.
見ました!
ちょっとそのままだと動作しなかったので、master をマージして動作確認しました
問題ないかと〜。アセット便利なのでほしい。
pleeeeeeeeeeeeeeeeeease の中身を postcss 側に移しても良さそう
というか pleeeeeeeeeeeeeeeeeeeeese の中身は postcss なので postcss on postcss 状態なのであった
|
これサンプルコード追加しても良いかも .sprite {
background-image: resolve("sample.png");
background-size: size("sample.png");
width: width("sample.png");
height: height("sample.png");
}みたいな → と思ったけど長くなるからこのプルリクはこのプルリクでマージすればOK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postcss-assets をSassで使えるように設定できたので一応p-rします。
デフォルトでは絶対パス��でresolveされます。
width("hoge.jpg") + 10pxみたいなのをしたい場合はcalc(width("hoge.jpg")+10px)とか書かないといけないかも(その後に
postcss-calcはさむと、 計算できるcalcを計算後で出力してくれたりする)(やってることはブログに書きました)(ブログは消滅しました)
http://be-into.com/blog/web/use-postcss-assets-through-sass/