Fixed an error when placing objects in a different bucket than the region running the Lambda function#18
Open
handlename wants to merge 8 commits intomasterfrom
Open
Fixed an error when placing objects in a different bucket than the region running the Lambda function#18handlename wants to merge 8 commits intomasterfrom
handlename wants to merge 8 commits intomasterfrom
Conversation
fujiwara
reviewed
May 17, 2024
| } | ||
|
|
||
| func (r *Router) getS3BucketRegion(ctx context.Context, bucket string) (string, error) { | ||
| if region, ok := r.s3bucketRegion[bucket]; ok { |
Contributor
There was a problem hiding this comment.
putToS3 might be called from multiple goroutines in parallel, so we have to guard concurrent map access. Please consider using sync.Mutex or another lock mechanism.
fujiwara
reviewed
May 20, 2024
Co-authored-by: FUJIWARA Shunichiro <fujiwara.shunichiro@gmail.com>
missed on 189c119
Contributor
Author
|
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the region running Lambda function is not same to destination S3 bucket, AWS API returns errors like berow:
To avoid this, added codes to init AWS API Client for each destination.
before (v0.1.1)
after