Skip to content

Fix dry-run execution, Docker socket config, and code formatting#4

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/sub-pr-3
Draft

Fix dry-run execution, Docker socket config, and code formatting#4
Copilot wants to merge 2 commits intomainfrom
copilot/sub-pr-3

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 15, 2026

Addresses review feedback from PR #3: --dry-run was executing subprocesses, Docker socket path hardcoded for non-Colima setups, and tab indentation in scripts.

Changes

  • Dry-run gating: build_env_sections() now accepts dry_run parameter and skips subprocess execution when true. Callers (setup_with_report, cleanup_with_report, report, doctor) pass the flag through.

  • Configurable Docker socket: defense-stack/docker-compose.yml uses ${DOCKER_SOCKET_PATH:-/var/run/docker.sock} for Colima compatibility (~/.colima/default/docker.sock).

  • Indentation cleanup: Converted tabs to spaces in ssh-brute-lab/ansible/scripts/ssh-bruteforce.py and applied Ruff formatting project-wide.

def build_env_sections(*, dry_run: bool) -> list[tuple[str, str]]:
    if dry_run:
        return [("Dry run", "No subprocesses executed. Remove --dry-run to capture live status.")]
    # ... actual subprocess calls

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: kazichaska <92224794+kazichaska@users.noreply.github.com>
Copilot AI changed the title [WIP] Update BootCon cyber lab toolkit with orchestration and modules Fix dry-run execution, Docker socket config, and code formatting Feb 15, 2026
Copilot AI requested a review from kazichaska February 15, 2026 21:23
Base automatically changed from 2026 to main February 15, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants