Swap deprecated np.int to int #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbarbary I would really appreciate if this pull request is accepted! |
|
@kbarbary could you please check this PR? |
|
Note that a fork is being maintained at https://github.com/AmpelAstro/sfdmap2 I have mentioned this in #2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since numpy v1.20, the use of aliases such as
np.inthave been deprecated (see e.g https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations). The recommended solution is to instead useint, which is equivalent. This PR replaces for four instances ofnp.intinsfdmap.pywithint.When I run the unit tests, I would previously get 38 warnings with numpy v1.22, but now get none.