Skip to content

Conversation

@MrCreosote
Copy link
Member

Based on code originally written by David Lyon here: #471

Based on code originally written by David Lyon here:
#471
@MrCreosote MrCreosote requested a review from dauglyon November 17, 2025 22:07
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dauglyon there's a couple of changes from your code I should note:

  • I removed the logging since the auth servier automatically logs any exception it gets.
  • I made the exception messages less specific since they get displayed to the users and I was worried about some or all of the JWT winding up in the message, although I don't think that's super likely, but better safe than sorry. The entire exception will be logged, so the specific message will be available there

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (d474311) to head (aa9b52a).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #498      +/-   ##
=============================================
+ Coverage      93.41%   93.44%   +0.02%     
  Complexity      2181     2181              
=============================================
  Files            129      129              
  Lines           7629     7659      +30     
  Branches        1191     1200       +9     
=============================================
+ Hits            7127     7157      +30     
  Misses           459      459              
  Partials          43       43              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCreosote MrCreosote merged commit 366044e into develop Nov 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants