Skip to content

Conversation

@jeff-cohere
Copy link
Collaborator

@jeff-cohere jeff-cohere commented Dec 18, 2025

This pair of changes prevent us from requesting file moves more than once after files are staged. It seems to fix an issue observed by Sophie in her custom CSU transfers.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

PR Preview Action v1.6.3

🚀 View preview at
https://kbase.github.io/dts/pr-preview/pr-195/

Built to branch gh-pages at 2025-12-18 18:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.03%. Comparing base (0812bc0) to head (6afb8ee).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
transfers/mover.go 71.42% 2 Missing ⚠️
transfers/stager.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   65.08%   65.03%   -0.05%     
==========================================
  Files          34       34              
  Lines        4459     4462       +3     
==========================================
  Hits         2902     2902              
- Misses       1236     1239       +3     
  Partials      321      321              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeff-cohere
Copy link
Collaborator Author

The only remaining test failures are related to a Globus endpoint we don't control, so I'm merging this.

@jeff-cohere jeff-cohere merged commit e7150b3 into main Dec 18, 2025
7 of 10 checks passed
@jeff-cohere jeff-cohere deleted the custom-xfer-issue branch December 18, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants