Unknown blocks for BE to JE should be air#1
Open
ElvinStarry wants to merge 1 commit intokbinani:mainfrom
Open
Conversation
Owner
|
Thank you for the PR. One thing I'm concerned about is how the converter behaves when the output-supported version is older than the input world's version. For example, when je2be-desktop supports Java Edition up to 1.21.4 but processes a Bedrock 1.21.10 world, there can be blocks newly added between 1.21.5 and 1.21.10. At the moment, I think there are several possible approaches:
I haven't fully evaluated which approach is best yet, but I'd like to choose the option that maximizes the benefit for users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cheaters leave many, many Education Edition blocks (e.g.
underwater_torch) around the world of my server years ago, and finding and pruning all of them is impossible for a years-old save that has 1.2GB.Literally copying block ID may cause an assertion error for non-JE and non-BE blocks, so they should be air when converted.
Simple patch, not tested, hope it will work.