Open
Conversation
…tion() in record.py, Update test files
… and find_cluster() functions
To test the members of aSDomain() and PFAM_domain()
Update GenericFeature() in record.py To test the class members of GenericFeature()
-Raise errors if a qualifier is not a member -Refine the code structure
Remove redundant code
return 0 if cluster number is not found
Bugs fix Remove __nonzero__() Remove get_secmet_features() Add members to Features
…covert them to str
…uch use here) Update docstings, refine code
…main Refine code, remove unnecessary checks for NoneType
Explicit check for None for score, evalue, cutoff and extension
Update docstrigns and inline comments Bug fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API for antiSMASH
Add more handling to Record class
Enable handling to sequences in various formats. At present fasta, genbank, embl.
Add setters to name, id, description, annotations, seq etc.
Parent class of all features present in a record.
ClusterFeature, CDSFeature, GenericFeature, CDS_motifFeature, aSDomain and PFAM_domain are added.
SubCDSFeature (parent class of CDS_motifFeature, aSDomain, PFAM_domain) eliminates code duplication due to common qualifiers among child classes.
Create hierarchies between cluster features and CDS features while parsing the sequence or when adding a new feature into the record. Achieved using _update_cluster_cds_links() method.
Strict type checking has been enabled to qualifiers. Numbers such as score, evalue, extension, cutoff are checked for valid form before using.
Appropriate errors are raised when something fails.
A new class SecMetQualifier is added to enable more handling on
sec_metqualifier.Existing test files are updated to test updated Record class.
New test files are added to test newly added features.
Code coverage: 98% (obtained using coverage library)
More test sequences added to test/data folder.