new library module fritztam #140
Conversation
library module to interact with integrated telephone answering machine (TAM)
|
Thank you for the pull request. I will come to a code review and testing when I find some time for that. So please be patient. |
|
Thank you. Take you time. I am happy to answer any questions you might have. |
| :members: | ||
|
|
||
|
|
||
| FritzTAM |
There was a problem hiding this comment.
I would avoid abbreviations like this. What about FritzAnsweringMachine ?
| internally. | ||
| """ | ||
| if self._sid_token is None: | ||
| sidResponse = self.fc.call_action("DeviceConfig", |
There was a problem hiding this comment.
Please use pep8 as coding style, i.e. sid_response. There are more issues like this in the code.
| return result | ||
|
|
||
| # @property | ||
| def tam_list(self): |
There was a problem hiding this comment.
name it tams or anything else, but don't but a type into the label (like _list here).
|
Hi, in case you are still interested, I've started with a first code review, but need some more time for a more detailed read. Thanks for your contribution. |
|
Hi. Yes I am still interested. Thank you. I will have a look an address your comments. I have just been a bit busy recently. |
|
Just stumbled in here, coming from Home Assistant and would love to see this implemented as fritzconnection is the underlying library used in HA. :) Can I do something to resolve this, and if so, what specifically or should I make a new PR to get this implemented? Thanks! |
|
Hey. I must say I lost interest in this. The original project, for which I wanted to use this, did not work out. (And then I had some git-struggles which prevented me from resolving the comments above.) Sorry for that. So @Paddy0174, feel free to make an new PR. I am happy that this seems to useful for somebody. |
|
I like this. |
|
+1 |
1 similar comment
|
+1 |
|
Hi , Are there any updates here? Is there already a complete code review (I would like to follow this pr) @kbr ? |
|
Is this still being looked at? |
8 participants
library module to interact with integrated telephone answering machine
(TAM)
Hey. I really like your python module and I added some basic support for the telephone answering machine, as I needed that.
If you are interested in adding this to the lib-directory, here is a pull request.
The module is documented in library.rst, so I refer to that file for details.
This is actually my first pull request ever, so if I did something wrong let me know an I will try to fix it.
Of course if you have any questions, I am happy to answer them.