Complex topics trigger a Protocol.UndefinedError#1
Open
stmichael wants to merge 1 commit intokbremner:masterfrom
Open
Complex topics trigger a Protocol.UndefinedError#1stmichael wants to merge 1 commit intokbremner:masterfrom
stmichael wants to merge 1 commit intokbremner:masterfrom
Conversation
Owner
|
Glad it's of some use! I wrote it to try out PG2 but if it's useful then that's good to hear :) Thanks for the PR, just 2 things. Could you update the spec statements, now that the methods can accept something other than strings, and could you add doc tests showing the use of a non-string topic? If you could make those changes, I can get this merged! |
83074bd to
bab532c
Compare
Author
|
Sorry, I forgot about that. How about now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this small but useful library. I write something very similar of my own and thought about publishing it. But then I stumbled upon your project which completely satisfies my needs.
I came across an issue. I need to have more complex topics than just plain string. Unfortunately that produced an error:
Here is a fix to this problem 😄