fix #658 Fail to import FCStd containing assembly workbench#659
Open
nodtem66 wants to merge 1 commit intokbwbe:masterfrom
Open
fix #658 Fail to import FCStd containing assembly workbench#659nodtem66 wants to merge 1 commit intokbwbe:masterfrom
nodtem66 wants to merge 1 commit intokbwbe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A FCStd file may contain the assembly workbench which A2Plus fails to import.
This PR adds the exclusion rules in
a2plib.filterShapeObsto filter assembly objects.Detail
The testing FCStd file could be found here: Test_exclude_assembly.FCStd.txt

It contains a cube and an assembly, shown below.
Step to reproduce an error
Workaround
TypeIdto filter out the assembly objectsAssembly::AssemblyObject.TypeId == Assembly::*does not filter theBody002andBody003(which areApp::Linkin Assembly). We also need to check the parents of the objects. If any of them is Assembly, the object will be excluded.Any feedback or comment is welcomed.