Create tech stack docs (techstack.yml and techstack.md) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinchapman
force-pushed
the
master
branch
from
c54093d to
9b2c24c
Compare
martinchapman
pushed a commit
that referenced
this pull request
Sep 6, 2024
* [example] batched-bench "segmentation fault" When `llama-batched-bench` is invoked _without_ setting `-npl`, "number of parallel prompts", it segfaults. The segfault is caused by invoking `max_element()` on a zero-length vector, `n_pl` This commit addresses that by first checking to see if the number of parallel prompts is zero, and if so sets the maximum sequence size to 1; otherwise, sets it to the original, the result of `max_element()`. Fixes, when running `lldb build/bin/llama-batched-bench -- -m models/Meta-Llama-3-8B.gguf` ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) frame #0: 0x000000010000366c llama-batched-bench`main(argc=3, argv=0x000000016fdff268) at batched-bench.cpp:72:28 69 llama_context_params ctx_params = llama_context_params_from_gpt_params(params); 70 71 // ensure enough sequences are available -> 72 ctx_params.n_seq_max = *std::max_element(n_pl.begin(), n_pl.end()); ``` * Update examples/batched-bench/batched-bench.cpp Co-authored-by: compilade <git@compilade.net> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> Co-authored-by: compilade <git@compilade.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tech stack documentation to allow anyone to easily see what is being used in this repo without digging through config files. Two files are being added:
techstack.ymlandtechstack.md.techstack.ymlcontains data on all the technologies being used in this repo.techstack.mdis a visualization of the YML file and displays the tech stack data in a pretty Markdown file.💡 Protip:
techstack.mdcontains a comment at the top of the file that the following README snippet (with and without the logos) at the top of the file as a comment:<--- Readme.md Snippet without images Start --->
Tech Stack
kclhi/llama.cpp is built on the following main stack:
Full tech stack here
<--- Readme.md Snippet without images End --->
Get the code:
<--- Readme.md Snippet with images Start --->
Tech Stack
kclhi/llama.cpp is built on the following main stack:
Full tech stack here
<--- Readme.md Snippet with images End --->
Get the code: