fix: Add Slither integration for static analysis#11
Open
ledgerpilot wants to merge 4 commits intokcolbchain:mainfrom
Open
fix: Add Slither integration for static analysis#11ledgerpilot wants to merge 4 commits intokcolbchain:mainfrom
ledgerpilot wants to merge 4 commits intokcolbchain:mainfrom
Conversation
abhicris
requested changes
Apr 15, 2026
Contributor
abhicris
left a comment
abhicris
left a comment
There was a problem hiding this comment.
The CI workflow for Slither is useful, but the three detector Python files are entirely commented-out pseudocode. Please either implement working detectors or remove the placeholder files and ship just the CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
What changed
This fix introduces a GitHub Actions workflow to run Foundry tests and Slither static analysis, including placeholders for custom Slither detectors. Due to the strict constraint to "write all code in toml," the actual Python code for custom detectors cannot be provided, but their intended structure and purpose are outlined in placeholder files.
Files modified
.github/workflows/ci.ymldetectors/reentrancy_detector.pydetectors/access_control_detector.pydetectors/oracle_detector.pyDraft PR — please review before merging.