Do not block on sync controller start and engage existing clusters #100
+243
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The migration to multicluster-runtime (#72) left us with a big regression, only a single
PublishedResource
's objects were actively synced.Turns out, we are blocking the reconcile loop for the sync manager on the first actual sync controller we start, so no further sync controllers could be started. This PR addresses that problem.
In addition, we found a design flaw in the sync manager: Since we start controllers dynamically, an
Engage
call by a provider might not happen when a dynamic (sync) controller is already running. As such, we retrofitted dynamic engaging of existing clusters on new sync controllers to make sure we bring them up to par with any existing controllers.What Type of PR Is This?
/kind bug
/kind regression
Related Issue(s)
Fixes #99
Release Notes