forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 1
Nnlops #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dteague
wants to merge
228
commits into
kdlong:GenWeightRefactor_master
Choose a base branch
from
dteague:nnlops
base: GenWeightRefactor_master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nnlops #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step to moving towards edm::OwnVector and polymorphic storage
First tests with parsing of lhe file. Need to incorp EDM lhe reader
fixing readerhelper problems
…nto Gen_parsing
…nto Gen_parsing
Need to look into more flexible implimentation/more error detection
fixing build errors
ie identifying nnlops group at is its own group Also for lowercase vs uppercase nnlops
ffceb52 to
caf24ab
Compare
036a6b4 to
0d3717a
Compare
fe25f03 to
f7a3156
Compare
f7a3156 to
393f1fc
Compare
258f6b0 to
5dee41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code as group setting for NNLOPS style weights as well as fixing a couple of errors persistent in the code (flag for failing on finding unassociated weights, allowing for filling of unassociated weights, fix problem with cmsDriver.py command with current
nanogenfile.)