Skip to content

improve field errors for failed sign in attempts #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
werronense wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve field errors for failed sign in attempts #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions web-app/app/actions-auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ export async function loginWithEmailPassword(
return {
lastInvocationStatus: "error",
error: {
fieldErrors: { password: "Unknown user or incorrect password" },
fieldErrors: {
password: "Unknown user or incorrect password",
email: "Unknown user or incorrect password",
},
},
};
} else {
Expand All @@ -53,7 +56,14 @@ export async function loginWithMagicLink(
? { lastInvocationStatus: "success" }
: {
lastInvocationStatus: "error",
error: { rootError: JSON.stringify(error) },
error:
error.code === "otp_disabled"
? {
fieldErrors: {
email: "Unknown user",
},
}
: { rootError: JSON.stringify(error) },
};
}

Expand Down