This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Avoid images being included in the npm package#14
Open
danielwhatmuff wants to merge 3 commits intokeepitcool:masterfrom
Open
Avoid images being included in the npm package#14danielwhatmuff wants to merge 3 commits intokeepitcool:masterfrom
danielwhatmuff wants to merge 3 commits intokeepitcool:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 4 4
Lines 175 175
Branches 52 52
=======================================
Hits 160 160
Misses 15 15 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying to serverless infra e.g. lambda, there is a hard limit of 50MB for the application size - these two images are taking up 2MB!