fix: add requires_message gate to BIP-85 tests#181
Merged
BitHighlander merged 1 commit intorelease/7.14.0from Mar 27, 2026
Merged
fix: add requires_message gate to BIP-85 tests#181BitHighlander merged 1 commit intorelease/7.14.0from
BitHighlander merged 1 commit intorelease/7.14.0from
Conversation
BIP-85 tests only had requires_firmware("7.14.0") which means they
run (and fail) when firmware reports 7.14.0 but the BIP-85 handler
is not yet compiled in. Add requires_message("GetBip85Mnemonic") to
setUp() so tests skip gracefully when the message type is unsupported,
matching the pattern used by Solana/TRON/TON/Zcash tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requires_message("GetBip85Mnemonic")to BIP-85 testsetUp()so tests skip gracefully when firmware has version 7.14.0 but BIP-85 handler is not yet compiled inrequires_firmware("7.14.0")from per-method tosetUp()(matches Solana/TRON/TON/Zcash pattern)Why
Firmware version bump is moving to the baseline (before BIP-85 handler lands). Without the message gate, BIP-85 tests would run and fail instead of skipping.
Test plan