fix: gate EVM clear-signing tests on EthereumTxMetadata#182
Merged
BitHighlander merged 1 commit intorelease/7.14.0from Mar 27, 2026
Merged
fix: gate EVM clear-signing tests on EthereumTxMetadata#182BitHighlander merged 1 commit intorelease/7.14.0from
BitHighlander merged 1 commit intorelease/7.14.0from
Conversation
Tests gate on EthereumSignTx which exists in all firmware versions. Should gate on EthereumTxMetadata (the new message) so tests skip when firmware lacks clear-signing support instead of running and failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requires_message("EthereumSignTx")→requires_message("EthereumTxMetadata")intest_msg_ethereum_clear_signing.pyWhy
EthereumSignTxexists in all firmware versions, so the gate never skips. When firmware reports 7.14.0 but lacks the clear-signing handler, tests run and fail instead of skipping.EthereumTxMetadatais the new message — correct gate target.Test plan