Skip to content

support temporal sdk 2.17#74

Merged
cappuc merged 4 commits intomainfrom
feat/temporal-sdk-2.17
Mar 6, 2026
Merged

support temporal sdk 2.17#74
cappuc merged 4 commits intomainfrom
feat/temporal-sdk-2.17

Conversation

@cappuc
Copy link
Copy Markdown
Contributor

@cappuc cappuc commented Mar 6, 2026

No description provided.

@cappuc cappuc marked this pull request as ready for review March 6, 2026 09:34
Copilot AI review requested due to automatic review settings March 6, 2026 09:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the package to support Temporal PHP SDK 2.17.x, including dependency constraints and test/support shims needed to match the updated SDK/Testbench expectations.

Changes:

  • Bump temporal/sdk to ~2.17.0 (and adjust related dependencies).
  • Update FakeWorkflowContext to implement newly required WorkflowContextInterface methods.
  • Adjust Testbench setup to explicitly register the package service provider; tweak PHPStan ignores for new analyzer behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/TestCase.php Switches Testbench bootstrapping to explicit provider registration for tests.
src/Testing/Fakes/FakeWorkflowContext.php Adds passthrough methods required by Temporal SDK 2.17’s workflow context interface.
phpstan.neon Ignores a new PHPStan rule identifier introduced/triggered by updated deps.
composer.json Updates dependency constraints for Temporal SDK 2.17 compatibility.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/TestCase.php Outdated
Comment on lines +16 to +20
protected function getPackageProviders($app)
{
return [
LaravelTemporalServiceProvider::class,
];
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPackageProviders() is introduced without a return type and without merging parent::getPackageProviders($app). Elsewhere in the test suite this method is typed (: array) and merges parent providers, and some Orchestra/Testbench versions define a return type on the parent method. To avoid potential signature incompatibilities and ensure any parent providers aren’t dropped, add : array here and merge with parent::getPackageProviders($app).

Suggested change
protected function getPackageProviders($app)
{
return [
LaravelTemporalServiceProvider::class,
];
protected function getPackageProviders($app): array
{
return array_merge(
parent::getPackageProviders($app),
[
LaravelTemporalServiceProvider::class,
]
);

Copilot uses AI. Check for mistakes.
@cappuc cappuc merged commit 46614ab into main Mar 6, 2026
10 of 12 checks passed
@cappuc cappuc deleted the feat/temporal-sdk-2.17 branch March 6, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants