Conversation
There was a problem hiding this comment.
Pull request overview
Updates the package to support Temporal PHP SDK 2.17.x, including dependency constraints and test/support shims needed to match the updated SDK/Testbench expectations.
Changes:
- Bump
temporal/sdkto~2.17.0(and adjust related dependencies). - Update
FakeWorkflowContextto implement newly requiredWorkflowContextInterfacemethods. - Adjust Testbench setup to explicitly register the package service provider; tweak PHPStan ignores for new analyzer behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/TestCase.php | Switches Testbench bootstrapping to explicit provider registration for tests. |
| src/Testing/Fakes/FakeWorkflowContext.php | Adds passthrough methods required by Temporal SDK 2.17’s workflow context interface. |
| phpstan.neon | Ignores a new PHPStan rule identifier introduced/triggered by updated deps. |
| composer.json | Updates dependency constraints for Temporal SDK 2.17 compatibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| protected function getPackageProviders($app) | ||
| { | ||
| return [ | ||
| LaravelTemporalServiceProvider::class, | ||
| ]; |
There was a problem hiding this comment.
getPackageProviders() is introduced without a return type and without merging parent::getPackageProviders($app). Elsewhere in the test suite this method is typed (: array) and merges parent providers, and some Orchestra/Testbench versions define a return type on the parent method. To avoid potential signature incompatibilities and ensure any parent providers aren’t dropped, add : array here and merge with parent::getPackageProviders($app).
| protected function getPackageProviders($app) | |
| { | |
| return [ | |
| LaravelTemporalServiceProvider::class, | |
| ]; | |
| protected function getPackageProviders($app): array | |
| { | |
| return array_merge( | |
| parent::getPackageProviders($app), | |
| [ | |
| LaravelTemporalServiceProvider::class, | |
| ] | |
| ); |
No description provided.