Feature: Linter (flake8) on GitHub Actions#102
Merged
keiohta merged 2 commits intokeiohta:masterfrom Aug 25, 2020
Merged
Conversation
E231: Add space after comma (,) E302: Add blank line E305: Add blank line F401: Remove unused import module E704: Make multi-line F821: Undefined standard_ops is replaced by tf F841: Remove unused local variables
Owner
|
Thanks for the really useful PR! I would like to confirm the following two things:
|
Contributor
Author
No. These are independent.
No. This PR shows linter "test" results for all PRs and pushes. |
Owner
|
@ymd-h Thanks for quick reply. I merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #101
This PR adds a job on GitHub Actions to run flake8 (Linter) at push and pull request.
This utilizes GitHub Super-Linter.
According to the previous PR (#95), some warnings and errors are ignored, which can be configurable at
.github/linters/.flake8.Additionally, a 3rd party copied file
tf2rl/misc/prepare_output_dir.pyis ignored, too.Some code style is also fixed. (58fb730)