Open
Conversation
Owner
|
Hi @ymd-h , thanks for brilliant PR!! I would really appreciate your continuous support! I checked changes of codes, and I think all of them would contribute improvement of ApeX performance.
Yeah, this is true. I also consider some workaround. Thanks! |
cpprb 10.5.2 imporoves performance of PrioritizedReplayBuffer and MPPrioritizedReplayBuffer.
Contributor
Author
|
I updated the PR.
On my local machine, (a part of) logs at It seems that Super Linter v3 is strangely broken and we need to upgrade to v4. (I will add soon.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR is for #117
MPPrioritizedReplayBuffer(multi-process version PER), which doesn't requires manual lockMPPrioritizedReplayBufferdoesn't lock whole buffer but critical section onlyget()method.SyncManagertrained_steps+=requires manual lock. See doc)writer.flush()(I just let TensorFlow flush. We might need to adjust flush timing for our needs)This improvement have larger effect for small network and/or simple
Env.I tested by running example/run_apex_dqn.py with default "CartPole-v0" on CPU machine.
Please test other Envs and/or on GPU.
P.S.
Weights distribution with multiple queues seems to be inefficient because of multiple copying.
I will continue to consider other solution.