Skip to content

Conversation

@joetime
Copy link

@joetime joetime commented Sep 27, 2018

I went ahead and fixed this issue. See before and after below. In BEFORE the across numbers 11, 12, 13, 14, 17, etc. are incorrect.

I also added an option for 'allow two letter words' that can be utilized in the future.

Note this also fixes/removes the total number of clues listed in the printout (i.e. it removes the unused ones).

Thanks for this amazing application! I have a few more ideas I'd like to implement, so hopefully you appreciate the help.

BEFORE:
screen shot 2018-09-27 at 8 31 06 am

AFTER:
screen shot 2018-09-27 at 8 30 48 am

@joetime joetime mentioned this pull request Sep 27, 2018
@maxmetcalfe
Copy link

Thanks for fixing this issue! I was able to apply your patch and create a sweet puzzle 😁

I noticed an issue where two letter words were not being assigned a number. In checkIsAcross() and checkIsDown(), I think you should reference xw.allowTwoLetterWords and not the global allowTwoLetterWords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants