Guid handling and explicit null handling#1
Open
Onkelborg wants to merge 1 commit intokeith5000:masterfrom
Open
Guid handling and explicit null handling#1Onkelborg wants to merge 1 commit intokeith5000:masterfrom
Onkelborg wants to merge 1 commit intokeith5000:masterfrom
Conversation
String guid to System.Guid fixed, proper handling of explicit null in json body ( {example: null } )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String guid to System.Guid fixed, proper handling of explicit null in json body ( {example: null } )
I haven't done any extensive testing, but these modifications seem to work for me. Use of TypeDescriptor allows Guid strings to be converted to real System.Guid - didn't work before. Checking of the keys in parameters (and use null instead of an empty string) allows for explicit null and the possibility to differentiate between null and empty strings.