feat(Chobby): add declarative sharing modes system#23
Open
keithharvey wants to merge 1032 commits intocombined_mod_optionsfrom
Open
feat(Chobby): add declarative sharing modes system#23keithharvey wants to merge 1032 commits intocombined_mod_optionsfrom
keithharvey wants to merge 1032 commits intocombined_mod_optionsfrom
Conversation
keithharvey
force-pushed
the
sharing_tab
branch
from
6c721e6 to
1069815
Compare
keithharvey
force-pushed
the
sharing_tab
branch
3 times, most recently
from
8400bc2 to
f3fbabc
Compare
keithharvey
force-pushed
the
sharing_tab
branch
12 times, most recently
from
22cbe19 to
3660660
Compare
keithharvey
force-pushed
the
sharing_tab
branch
12 times, most recently
from
3b1c0f4 to
0e8daa6
Compare
keithharvey
force-pushed
the
sharing_tab
branch
2 times, most recently
from
9c3b18a to
17e9892
Compare
…ond-all-reason#7137) <!-- Fix: Prevent air units built with /nocost from remaining neutral --> ### Work done <!-- Modified unit_neutral_fix.lua to address a race condition occurring when units are finished instantly via the /nocost cheat. The logic now utilizes a GameFrame queue to ensure SetUnitNeutral(unitID, false) is called effectively after the unit has fully initialized in the engine. --> <!-- If relevant #### Addresses Issue(s) - Issue URL --> <!-- If relevant #### Setup NA --> #### Test steps Queue any aircraft while /nocost is active. Expected Result: The unit finishes instantly and, upon exiting the lab, transitions correctly from neutral (gray) to the player's team (standard health bar). Verification: Confirm the unit is immediately targetable and controllable as a standard unit. <!-- If relevant ### Screenshots: NA #### BEFORE: (screenshot from master) #### AFTER: (screenshot from branch) --> <!-- If relevant ### AI / LLM usage statement: I used Gemini to check over my code and make all necessary adjustments. It helped ensure the fix correctly addressed the race condition and strictly followed the BAR performance guidelines (caching engine calls, avoiding table churn, and using the proper GameFrame queue logic). -->
…ond-all-reason#6350) - Change `ColorIsDark()` to use the Y' luminance from CIE XYZ to detect darkness - Adjust the outline size and weight in `camera_player_tv` widget to better handle white outlines - For `gui_advplayerslist`, the white outline on this UI looks awful, so I kept the old `ColorIsDark()`. I tried to play with the outline weight and size, but [the results are pretty bad](https://github.com/user-attachments/assets/87b64b03-ee1a-4339-8951-011733aee0a0).
…sport giving a load/unload command) (beyond-all-reason#6351) Have the AllowCommand gadget call-in return false if the selected unit isn't a transport for the commands CMD_LOAD_UNITS and CMD_UNLOAD_UNITS
Include the Lux package manager so that we can manage packages. Updates the README and adds core testing dependencies. Lux seems like it is set to become the de facto package manager for lua and it is also not luarocks.
Add a set of configuration defaults, CI, and mocks/builders for the busted unit testing framework with an example spec. Updated the readme with installation instructions and examples.
…er surface (beyond-all-reason#6982) It's been reported that Brimstone (corfship) ship is considered untargetable by emp units (like Shurikens). The issue here stems from the fact we disallow EMPing targets that are below water's surface level (y <= 0). When floating on the surface Brimstone has a constant y of -1.
…d-all-reason#6984) Add queueing support to transport factory guard. Before, it would drop everything and activate the ferry immediately. Now, it supports queueing the guard. Add an option for the ferry to ignore units that were given an explicit user command while being built. Remove the old transport AI option, since this ferry thing supersedes it, and is better.
…7119) In the Umbrella unit script, set the isOpen flag earlier to avoid !isOpen animations running when trying to open and fire the anti-nuke. The same change also prevents various Stop orders (and engine behaviors that emulate them) from causing similar contention between animations.
keithharvey
force-pushed
the
sharing_tab
branch
from
ce774d4 to
5b33353
Compare
We can now send many named variables to interpolation and as long as we're using the named parameter pattern instead of the string interpolation pattern we're fine to send too many.
keithharvey
force-pushed
the
sharing_tab
branch
from
5b33353 to
8cb6740
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My own copy of the BAR PR #23, which thanks to having cherry-picked mod options in it is noisy. This targets the modoptions branch.