[Types] Migrate Spring Split

[keithharvey]

Commands

Demonstrates running bar-lua-codemod with:

# spring-split - split Spring into SpringSynced, SpringUnsynced, and SpringShared
bar-lua-codemod spring-split --path "$BAR_DIR" --library "$BAR_DIR/recoil-lua-library/library" --exclude common/luaUtilities

See RecoilEngine#2799 for the SpringSynced/SpringUnsynced/SpringShared type split on the engine side.

Output Summary

  Loaded 782 method mappings from /var/home/daniel/code/BAR-Devtools/Beyond-All-Reason/recoil-lua-library/library
bar-lua-codemod spring-split results:
  Method mappings loaded:                  782
  Files scanned:                         2,364
  Files changed:                           751
  Spring.X -> Specific.X conversions:    9,790
  Unmapped Spring.X references:          2,105
  Errors (parse failures):                   0

Top files by conversion count:
  luaui/Widgets/gui_options.lua                                  654
  luaui/Widgets/gui_pip.lua                                      445
  luarules/gadgets/cmd_dev_helpers.lua                           240
  luarules/gadgets/scav_spawner_defense.lua                      158
  luarules/gadgets/cus_gl4.lua                                   144
  luarules/gadgets/unit_zombies.lua                              102
  luaintro/springconfig.lua                                       97
  luaui/Widgets/gui_pregame_build.lua                             81
  luaui/Widgets/gui_advplayerslist_music_new.lua                  80
  luaui/Widgets/gui_advplayerslist.lua                            77
  luarules/gadgets/map_atmosphere_cegs.lua                        76
  luaui/Widgets/gui_info.lua                                      75
  luarules/gadgets/game_initial_spawn.lua                         66
  luaui/Widgets/gui_chat.lua                                      65
  luarules/gadgets/unit_hats.lua                                  63
  luarules/gadgets/raptor_spawner_defense.lua                     60
  luarules/gadgets/unit_carrier_spawner.lua                       59
  luaui/Widgets/gui_pregameui_draft.lua                           56
  luarules/Utilities/damgam_lib/position_checks.lua               55
  luaui/Widgets/map_startbox.lua                                  53

Unmapped Spring.X methods (21 unique):
  I18N                                                1416
  Utilities                                            253
  GetMyTeamID                                          127
  GetMyAllyTeamID                                      113
  GetMyPlayerID                                        108
  Debug                                                 43
  Lava                                                  15
  SetUnitCOBValue                                        8
  GetModOptionsCopy                                      5
  GetProjectileName                                      3
  ConnectController                                      2
  DisconnectController                                   2
  GetAvailableControllers                                2
  ZlibCompress                                           1
  TimeCheck                                              1
  GetGroupAIName                                         1
  ZlibDeCompress                                         1
  GameFrame                                              1
  CMD                                                    1
  GetUnitCOBValue                                        1
  GetControllerState                                     1

Branch Topology

All branches are generated from branch by just bar::fmt-mig-generate.

Leaf branches (each isolates one transform on top of fmt):

Branch	Transform	Diff
fmt	stylua . (base)	1415 files, +177785 −182643 vs stylua
├ mig-bracket	bracket-to-dot	348 files, +7638 −7649 vs fmt
├ mig-rename-aliases	rename-aliases	169 files, +359 −370 vs fmt
├ mig-detach-bar-modules	detach-bar-modules	169 files, +1527 −1538 vs fmt
├ mig-spring-split	spring-split	756 files, +9510 −9517 vs fmt

Linear branch (all transforms applied sequentially — this is what merges):

Branch	Commits	Diff vs stylua
mig	fmt → bracket-to-dot → rename-aliases → detach-bar-modules → spring-split	1427 files, +186612 −191465