Open
Conversation
Co-authored-by: Bilal Elmoussaoui <belmouss@redhat.com>
kellpossible
reviewed
Mar 5, 2024
| log::error!( | ||
| target: "i18n_embed::assets", | ||
| "Filename {:?} is not valid UTF-8.", | ||
| match globwalk::GlobWalkerBuilder::new(&self.base_dir, "*").build() { |
Owner
There was a problem hiding this comment.
Perhaps we can leave the walkdir dependency here because we aren't yet using any globwalk features from what I can tell, and it is already an internal dependency of globwalk?
Owner
|
Thanks for the contribution! It needs a |
|
GNU gettext 0.24 and newer supports the Rust programming language. So, when you say that this PR adds support "for running xgettext over non-rust files", AFAICS it also adds support for running xgettext over Rust source files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm building a GTK application where lots of translation strings exist inside Gnome Builder *.ui files.
This PR adds support for running xgettext over non-rust files.
My
i18n.tomlfile now looks like this: