Skip to content

Add convention: search before deleting or renaming files #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kelos-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add convention: search before deleting or renaming files #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- **Logging conventions.** Start log messages with capital letters and do not end with punctuation.
- **Commit messages.** Do not include PR links in commit messages.
- **Kubernetes resource comparison.** Use semantic `.Equal()` or `.Cmp()` methods for `resource.Quantity` comparisons, not `reflect.DeepEqual` — structurally different Quantity values can be semantically identical (e.g., `1000m` vs `1` CPU).
- **Search before deleting or renaming.** Before removing, moving, or renaming files, search the entire codebase for all references to those files (including test infrastructure, configs, and documentation) and update them. Do not rely on CI to catch broken references.

## Key Makefile Targets
- `make verify` — run all verification checks (lint, fmt, vet, etc.).
Expand Down
1 change: 1 addition & 0 deletions self-development/agentconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ spec:
- Commit messages: do not include PR links in commit messages
- When making structural changes (adding new files, configs, or components), update related documentation (especially README files) to stay in sync
- Kubernetes resource comparison: use semantic `.Equal()` or `.Cmp()` methods for `resource.Quantity` comparisons, not `reflect.DeepEqual`
- Search before deleting or renaming: before removing, moving, or renaming files, search the entire codebase for all references (including tests and configs) and update them
Loading