Skip to content

Add pre-push verification and cross-surface update conventions#786

Open
kelos-bot[bot] wants to merge 2 commits intomainfrom
kelos-config-update-latest
Open

Add pre-push verification and cross-surface update conventions#786
kelos-bot[bot] wants to merge 2 commits intomainfrom
kelos-config-update-latest

Conversation

@kelos-bot
Copy link

@kelos-bot kelos-bot bot commented Mar 24, 2026

/kind cleanup

What this PR does / why we need it:

Adds agent conventions based on recurring review feedback:

  1. Run make verify and make test before pushing — Workers and PR-responder agents previously pushed code before running any local verification, causing preventable CI failures. Now verification is required before the initial push in both "new PR" and "existing PR" flows.

  2. Update all related surfaces together — When changing user-facing guidance, agents must search for all surfaces (docs, CLI output, templates, code comments) that reference the same topic and update them together to avoid inconsistencies.

  3. Provider-agnostic API design — When adding CRD fields or API types, prefer generic abstractions over provider-specific ones (e.g., none credential type instead of bedrock). Use existing generic mechanisms like PodOverrides.Env for provider-specific details.

  4. Idiomatic Helm values — Use nested dictionary structures in values.yaml (e.g., controller.resources.requests.cpu) instead of flat string-based parameters. Structured data should be proper YAML dictionaries, not strings.

Evidence from PR reviews:

Files changed:

  • self-development/kelos-workers.yaml — Add verification step before push in both PR-exists (5a) and no-PR (new step 4b) flows
  • self-development/kelos-pr-responder.yaml — Add verification before commit+push in step 5
  • self-development/agentconfig.yaml — Add cross-surface consistency, provider-agnostic API, and Helm conventions
  • AGENTS.md / CLAUDE.md — Add cross-surface consistency, provider-agnostic API, and Helm conventions

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

All new conventions are backed by specific PR review evidence. No speculative rules added.

Does this PR introduce a user-facing change?

NONE

Address recurring review feedback: agents should run make verify/test
before pushing (not just after), and should update all related surfaces
when changing user-facing guidance.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Based on review feedback from recent PRs:
- PR #785: reviewer required generic `none` credential type instead of
  AWS-specific `bedrock`, establishing provider-agnostic API design
- PR #783: multiple review rounds corrected flat string Helm values to
  idiomatic nested dictionaries (controller.resources.requests|limits)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant