-
Notifications
You must be signed in to change notification settings - Fork 13
feat(ci): allow for supporting multi-arch images to be built and shipped #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| FROM golang:1.25 AS builder | ||
| WORKDIR /workspace | ||
| COPY go.mod go.sum ./ | ||
| RUN go mod download | ||
| COPY . . | ||
| RUN CGO_ENABLED=0 go build -o bin/kelos-controller ./cmd/kelos-controller | ||
|
|
||
| FROM gcr.io/distroless/static:nonroot | ||
| WORKDIR / | ||
| COPY bin/kelos-controller . | ||
| COPY --from=builder /workspace/bin/kelos-controller . | ||
| USER 65532:65532 | ||
| ENTRYPOINT ["/kelos-controller"] |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,12 @@ | ||||||
| FROM golang:1.25 AS builder | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: New builder base image uses a floating tag ( Prompt for AI agents
Suggested change
|
||||||
| WORKDIR /workspace | ||||||
| COPY go.mod go.sum ./ | ||||||
| RUN go mod download | ||||||
| COPY . . | ||||||
| RUN CGO_ENABLED=0 go build -o bin/kelos-spawner ./cmd/kelos-spawner | ||||||
|
|
||||||
| FROM gcr.io/distroless/static:nonroot | ||||||
| WORKDIR / | ||||||
| COPY bin/kelos-spawner . | ||||||
| COPY --from=builder /workspace/bin/kelos-spawner . | ||||||
| USER 65532:65532 | ||||||
| ENTRYPOINT ["/kelos-spawner"] | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,10 @@ | ||
| FROM golang:1.25 AS builder | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Builder toolchain is decoupled from Prompt for AI agents |
||
| WORKDIR /workspace | ||
| COPY go.mod go.sum ./ | ||
| RUN go mod download | ||
| COPY . . | ||
| RUN CGO_ENABLED=0 go build -o bin/kelos-capture ./cmd/kelos-capture | ||
|
|
||
| FROM ubuntu:24.04 | ||
|
|
||
| ARG GO_VERSION=1.25.0 | ||
|
|
@@ -30,7 +37,7 @@ ENV PATH="/usr/local/go/bin:${PATH}" | |
| COPY cursor/kelos_entrypoint.sh /kelos_entrypoint.sh | ||
| RUN chmod +x /kelos_entrypoint.sh | ||
|
|
||
| COPY bin/kelos-capture /kelos/kelos-capture | ||
| COPY --from=builder /workspace/bin/kelos-capture /kelos/kelos-capture | ||
|
|
||
| RUN useradd -u 61100 -m -s /bin/bash agent | ||
| RUN mkdir -p /home/agent/.cursor && chown -R agent:agent /home/agent | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,10 @@ | ||||||
| FROM golang:1.25 AS builder | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Builder stage uses a floating Go image tag, making release artifacts non-reproducible across rebuilds. Prompt for AI agents
Suggested change
|
||||||
| WORKDIR /workspace | ||||||
| COPY go.mod go.sum ./ | ||||||
| RUN go mod download | ||||||
| COPY . . | ||||||
| RUN CGO_ENABLED=0 go build -o bin/kelos-capture ./cmd/kelos-capture | ||||||
|
|
||||||
| FROM ubuntu:24.04 | ||||||
|
|
||||||
| ARG GO_VERSION=1.25.0 | ||||||
|
|
@@ -33,7 +40,7 @@ RUN npm install -g @google/gemini-cli@${GEMINI_CLI_VERSION} | |||||
| COPY gemini/kelos_entrypoint.sh /kelos_entrypoint.sh | ||||||
| RUN chmod +x /kelos_entrypoint.sh | ||||||
|
|
||||||
| COPY bin/kelos-capture /kelos/kelos-capture | ||||||
| COPY --from=builder /workspace/bin/kelos-capture /kelos/kelos-capture | ||||||
|
|
||||||
| RUN useradd -u 61100 -m -s /bin/bash agent | ||||||
| RUN mkdir -p /home/agent/.gemini && chown -R agent:agent /home/agent | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: New builder stage uses an unpinned
golangimage tag, making shipped binary builds non-deterministic and vulnerable to upstream image drift.Prompt for AI agents