Fix RangeError on multi-line link/image titles#1
Merged
kenforthewin merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Lezer emits LinkTitle / URL nodes that span newlines when CommonMark allows (multi-line titles, wrapped autolinks). The inline-preview ViewPlugin was pushing Decoration.replace for those nodes directly, which throws "Decorations that replace line breaks may not be specified via plugins" at build time. Route every replace in the plugin through a pushReplace helper that per-line-splits the range (first segment carries any widget, rest are plain hides). Single-line ranges hit the early-return and push the original spec unchanged, so common-case output is byte-identical. Covered by a new multiline-decoration.test.tsx regression test; the Playwright harness still passes 50/50 with no CLS deltas. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lezer emits LinkTitle / URL nodes that span newlines when CommonMark allows (multi-line titles, wrapped autolinks). The inline-preview ViewPlugin was pushing Decoration.replace for those nodes directly, which throws "Decorations that replace line breaks may not be specified via plugins" at build time.
Route every replace in the plugin through a pushReplace helper that per-line-splits the range (first segment carries any widget, rest are plain hides). Single-line ranges hit the early-return and push the original spec unchanged, so common-case output is byte-identical.
Covered by a new multiline-decoration.test.tsx regression test; the Playwright harness still passes 50/50 with no CLS deltas.