add go-mod support and turkish chars + golangci-lint#31
Open
vigo wants to merge 1 commit intokennygrant:masterfrom
Open
add go-mod support and turkish chars + golangci-lint#31vigo wants to merge 1 commit intokennygrant:masterfrom
vigo wants to merge 1 commit intokennygrant:masterfrom
Conversation
|
When contributing to a project, you should consider not unnecessarily changing formatting and separating your changes with different commits and PRs. This allows the maintainer to reduce their own overhead and maybe only merge some PRs, instead of all changes, if not everything is agreed with. @vigo |
Author
|
well, i did not changed a lot. just gofumpted code. added 3-4 lines (chars for mapping Turkish letters). if you check you'll see nothing big has changed 8) |
|
You are missing the point of my comment ^^ Either way, I am not the maintainer and that was just a friendly tip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.