Skip to content

Remove xgoogle and perform script wide cleanup #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FelixVicis wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Remove xgoogle and perform script wide cleanup #1

FelixVicis wants to merge 22 commits into from

Conversation

@FelixVicis
Copy link

@FelixVicis FelixVicis commented Nov 19, 2016

modifications include:

  • remove xgoogle/
  • refactor script to use BeautifulSoup v4 and MarioVilas/google
  • fix .gitignore
  • add requirements.txt and essential installation documentation
  • separate script behavior from class functionality

FelixVicis and others added 22 commits November 19, 2016 12:27
@FelixVicis
chore(.gitignore): add .csv files to gitignore
bb23e2f
@FelixVicis
refactor(xgoogle): remove other project files
359981a
@FelixVicis
fix(main.py): use package google for searching
9e6dfc4 
this is to remove xgoogle as that package no longer functions
@FelixVicis
chore: add requirements.txt
50955a4 
this will serve better for our users to install the dependancies themselves
@FelixVicis
chore: add setup.bash
a071dd0 
this is a script to automatically run the pip install and quickly install package google manually
@FelixVicis
chore: add installation segment to readme.txt
9d04ed2
@FelixVicis
refactor(main.py): move script behavior behind __main__
be00b3a
@FelixVicis
fix(main.py): move variables into global scope
52957df
@FelixVicis
chore(.gitignore): properly ignore files
e360def
@FelixVicis
fix: handle http errors when accessing websites
1ab6eb8 
Previous behavior had the script exit at any error. This change now logs a warning when, due to an http error, the website cannot be accessed.

fixes #1
@FelixVicis
chore: clean up code styles (#3)
9a8f71b 
* style: organize imports

* style: remove whitespace

* style: remove extra line

* style: remove whitespace

* style: remove whitespace

* style: remove whitespace

* style: break long lines

* style: remove whitespace
@FelixVicis
doc: update installation docs to be more straight forward
cade778
@FelixVicis
chore: remove example csv
7b1f7cc
@FelixVicis
Merge pull request #5 from FelixVicis/chore/remove-csv
06f7b35 
chore: remove example csv
@FelixVicis
Merge pull request #4 from FelixVicis/doc/installation
c498f20 
doc: update installation docs to be more straight forward
@FelixVicis
fix: not all pages have titles.
7d7c0b1 
good to know.

fixes #6
@FelixVicis
refactor: break some of this behavior up
bdf5ba8
@FelixVicis
chore: add contributing guidelines
3e9c1bc
@FelixVicis
chore: add codereviewers for pulls
edcb4c6
@FelixVicis
chore: pull license message out into file
bb8a25a 
Replacing the GNU license with MIT, same overall goal.
@spriggsj
fix add try-catches to not have so many errors
c0edda1
@FelixVicis
Merge pull request #7 from FelixVicis/fix/add-try-catches
3c22116 
fix add try-catches to not have so many errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FelixVicis @spriggsj