Open
Conversation
…position bug needs to be fixed
Collaborator
|
This looks good to me overall. A few things I'd comment is:
Also, leave a comment here, or update your pull request description, when the todo list is complete, if it isn't already. :) |
Collaborator
Author
|
@Kronopath Thanks for your thoughts. The union of sets makes most sense now, so maybe one tag per sketch should be enforced after all? Also, any thoughts on the reset functionality? I'm still not sure how it should be represented. |
Collaborator
|
I'm not really sure I have much of a better idea of how to implement reset right now. Having it as a button like the tag buttongs (maybe with some slight visual differentiation) makes some sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, Please do not merge before To-Do list completed, thoughts appreciated
Changes
this.tag = "tagName"orthis.tags = ["tagName1", ... "tagNameN"]properties to assign a tag (or a few).To-Do
Hard-to-see but visible enough GIF demo