-
Notifications
You must be signed in to change notification settings - Fork 200
Fix lighthouse_comment workflow to handle workflow_run event context #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-lighthouse-github-action-run
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
180e95b
Initial plan
Copilot 9337f20
Fix lighthouse_comment.yml to properly handle workflow_run event
Copilot 2289cc1
Add documentation for Lighthouse workflow fix
Copilot cc84881
Address code review feedback - add PR number validation and remove re…
Copilot a510977
Update documentation to match implementation and add explanatory comm…
Copilot 4a4ef7d
Add clarification about github-token not being needed
Copilot 5202ddf
Remove .github/LIGHTHOUSE_FIX.md documentation file
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -13,20 +13,36 @@ permissions: | |||||
| jobs: | ||||||
| comment: | ||||||
| runs-on: ubuntu-latest | ||||||
| if: github.event.workflow_run.conclusion == 'success' | ||||||
|
|
||||||
| steps: | ||||||
| # Download artifacts from the completed "Lighthouse – Run" workflow | ||||||
| # The run-id parameter is critical - it specifies to download from the | ||||||
| # triggering workflow run, not the current workflow (which has no artifacts) | ||||||
| # Note: github-token is not needed as the default GITHUB_TOKEN has sufficient | ||||||
| # permissions to download artifacts from the same repository | ||||||
| - name: Download Lighthouse comment artifact | ||||||
| uses: actions/download-artifact@v4 | ||||||
| with: | ||||||
| name: lighthouse-comment | ||||||
| path: . | ||||||
| run-id: ${{ github.event.workflow_run.id }} | ||||||
|
|
||||||
| - name: Ensure comment file exists | ||||||
| run: test -f lighthouse-comment.md | ||||||
|
|
||||||
| - name: Extract PR number | ||||||
| id: pr | ||||||
| run: | | ||||||
| PR_NUMBER=$(jq -r '.workflow_run.pull_requests[0].number' <<< '${{ toJSON(github.event) }}') | ||||||
| if [ -z "$PR_NUMBER" ] || [ "$PR_NUMBER" = "null" ]; then | ||||||
| echo "❌ Error: Could not extract PR number from workflow run event" | ||||||
|
||||||
| echo "❌ Error: Could not extract PR number from workflow run event" | |
| echo "❌ Error: Could not extract a PR number from the workflow_run event. This usually means the triggering workflow run was not associated with a pull request or workflow_run.pull_requests was empty. Next, check that the upstream \"Lighthouse – Run\" workflow was triggered by a pull_request-related event and confirm the repository/workflow settings allow PR context to be included in workflow_run payloads." |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions/download-artifact@v4withrun-idcalls the Actions Artifacts API; with the workflow-levelpermissions:block present, the defaultGITHUB_TOKENno longer has implicitactions: read. This will typically fail withResource not accessible by integration. Addactions: read(or remove the explicit permissions block and set least-privilege explicitly includingactions: read) so the artifact download can succeed.