-
Notifications
You must be signed in to change notification settings - Fork 200
feat: redesign testimonial marquee with manual controls, add security,headers, and fix SEO issues #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HEETMEHTA18
wants to merge
6
commits into
keploy:main
Choose a base branch
from
HEETMEHTA18:feat/testimonial-marquee-redesign
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: redesign testimonial marquee with manual controls, add security,headers, and fix SEO issues #335
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d2bd412
feat: redesign testimonial marquee with manual controls, add security…
HEETMEHTA18 7e29072
feat: redesign testimonial marquee, add security headers, and fix SEO…
HEETMEHTA18 7979489
refactor: remove unused useCallback and useMemo imports
HEETMEHTA18 c0565d4
Merge branch 'main' into feat/testimonial-marquee-redesign
HEETMEHTA18 07e60d4
Merge branch 'main' into feat/testimonial-marquee-redesign
HEETMEHTA18 14b865e
Merge branch 'main' into feat/testimonial-marquee-redesign
HEETMEHTA18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,8 +1,28 @@ | ||||||||||||||||||||||||||||||||||||||||||
| import React from "react"; | ||||||||||||||||||||||||||||||||||||||||||
| import React, { useState } from "react"; | ||||||||||||||||||||||||||||||||||||||||||
| import { useRouter } from "next/router"; | ||||||||||||||||||||||||||||||||||||||||||
| import { Marquee } from "./Marquee"; | ||||||||||||||||||||||||||||||||||||||||||
| import Tweets from "../services/Tweets"; | ||||||||||||||||||||||||||||||||||||||||||
| const firstRow = Tweets.slice(0, Tweets.length / 2); | ||||||||||||||||||||||||||||||||||||||||||
| const secondRow = Tweets.slice(Tweets.length / 2); | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| const firstRow = Tweets.slice(0, Math.ceil(Tweets.length / 2)); | ||||||||||||||||||||||||||||||||||||||||||
| const secondRow = Tweets.slice(Math.ceil(Tweets.length / 2)); | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| import { User } from "lucide-react"; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| /** Generates a two-letter initial from a name string */ | ||||||||||||||||||||||||||||||||||||||||||
| const getInitials = (name: string): string => { | ||||||||||||||||||||||||||||||||||||||||||
| const parts = name.trim().split(/\s+/); | ||||||||||||||||||||||||||||||||||||||||||
| if (parts.length >= 2) { | ||||||||||||||||||||||||||||||||||||||||||
| return (parts[0][0] + parts[parts.length - 1][0]).toUpperCase(); | ||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||
| return name.slice(0, 2).toUpperCase(); | ||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| /** Fallback avatar component – renders a user icon/initials in a branded circle */ | ||||||||||||||||||||||||||||||||||||||||||
| const FallbackAvatar = ({ name }: { name: string }) => ( | ||||||||||||||||||||||||||||||||||||||||||
| <div className="flex h-10 w-10 shrink-0 items-center justify-center rounded-full bg-slate-100 text-slate-500 ring-2 ring-gray-100 p-1"> | ||||||||||||||||||||||||||||||||||||||||||
| <User className="h-full w-full opacity-60" /> | ||||||||||||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+20
to
26
|
||||||||||||||||||||||||||||||||||||||||||
| /** Fallback avatar component – renders a user icon/initials in a branded circle */ | |
| const FallbackAvatar = ({ name }: { name: string }) => ( | |
| <div className="flex h-10 w-10 shrink-0 items-center justify-center rounded-full bg-slate-100 text-slate-500 ring-2 ring-gray-100 p-1"> | |
| <User className="h-full w-full opacity-60" /> | |
| </div> | |
| ); | |
| /** Fallback avatar component – renders initials when available, otherwise a user icon */ | |
| const FallbackAvatar = ({ name }: { name: string }) => { | |
| const initials = name.trim() ? getInitials(name) : ""; | |
| return ( | |
| <div className="flex h-10 w-10 shrink-0 items-center justify-center rounded-full bg-slate-100 text-slate-500 ring-2 ring-gray-100 p-1"> | |
| {initials ? ( | |
| <span className="text-sm font-medium leading-none">{initials}</span> | |
| ) : ( | |
| <User className="h-full w-full opacity-60" /> | |
| )} | |
| </div> | |
| ); | |
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CoverImagenow usescn(...)but the helper isn’t imported in this file, which will cause a runtime/compile failure. Also, the Tailwind classestransition-borderandtransition-scaledon’t exist in this repo’s Tailwind config, so the intended transitions won’t apply; use valid Tailwind transition utilities (or extend Tailwind) instead.