feat: add test sets for SSE port, protocol config, and port mapping#212
Merged
officialasishkumar merged 1 commit intomainfrom Mar 26, 2026
Merged
feat: add test sets for SSE port, protocol config, and port mapping#212officialasishkumar merged 1 commit intomainfrom
officialasishkumar merged 1 commit intomainfrom
Conversation
Member
officialasishkumar
commented
Mar 26, 2026
officialasishkumar
commented
- Add /ping endpoint on HTTP mux and new ping server on :8050
- SKIP_PING_SERVER env var to disable ping server for port mapping CI tests
- Record port-config-test: mixed HTTP (:8000) + SSE (:8047) requests
- Record port-mapping-test: requests to :8050 for port mapping validation
- Update keploy.yml with ssePort, protocol config, and per-test-set port mapping
- Add /ping endpoint on HTTP mux and new ping server on :8050 - SKIP_PING_SERVER env var to disable ping server for port mapping CI tests - Record port-config-test: mixed HTTP (:8000) + SSE (:8047) requests - Record port-mapping-test: requests to :8050 for port mapping validation - Update keploy.yml with ssePort, protocol config, and per-test-set port mapping
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional Keploy test-sets and configuration to validate multi-port behavior (HTTP + SSE) and port-mapping during CI, including a dedicated ping endpoint/server to exercise port replacement behavior.
Changes:
- Add
/pingendpoint on the HTTP mux and an optional dedicated ping server on:8050(toggleable viaSKIP_PING_SERVER). - Add new recorded Keploy test-sets for port-configuration (mixed HTTP + SSE) and port-mapping validation (requests to
:8050). - Update
keploy.ymlwithssePort, explicit protocol port config, and per-test-set port mapping.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| http-sse/main.go | Adds optional ping server on :8050 and /ping route for port-mapping validation alongside existing HTTP/SSE servers. |
| http-sse/keploy.yml | Adds ssePort, protocol port config, and per-test-set port mapping for port-mapping-test. |
| http-sse/keploy/port-mapping-test/tests/test-1.yaml | New recorded HTTP test case for port-mapping test-set. |
| http-sse/keploy/port-mapping-test/tests/test-2.yaml | New recorded /ping request against :8050 for port-mapping validation. |
| http-sse/keploy/port-mapping-test/tests/test-3.yaml | Additional recorded /ping request against :8050 for port-mapping validation. |
| http-sse/keploy/port-mapping-test/tests/test-4.yaml | New recorded HTTP health request for port-mapping test-set. |
| http-sse/keploy/port-mapping-test/tests/test-5.yaml | New recorded HTTP /api/hello request for port-mapping test-set. |
| http-sse/keploy/port-config-test/tests/test-1.yaml | New recorded HTTP health request for port-config test-set. |
| http-sse/keploy/port-config-test/tests/test-2.yaml | New recorded HTTP health request for port-config test-set. |
| http-sse/keploy/port-config-test/tests/test-3.yaml | New recorded HTTP /api/hello request for port-config test-set. |
| http-sse/keploy/port-config-test/tests/test-4.yaml | New recorded HTTP /api/echo request for port-config test-set. |
| http-sse/keploy/port-config-test/tests/test-5.yaml | New recorded HTTP /api/add request for port-config test-set. |
| http-sse/keploy/port-config-test/tests/test-6.yaml | New recorded HTTP /api/resource/:id request for port-config test-set. |
| http-sse/keploy/port-config-test/tests/test-7.yaml | New recorded SSE student stream request against :8047 for port-config test-set. |
| http-sse/keploy/port-config-test/tests/test-8.yaml | New recorded SSE teacher stream request against :8047 for port-config test-set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+33
| // Optional ping server on :8050; disabled via SKIP_PING_SERVER=1 so that | ||
| // CI can validate replaceWith port-mapping (8050→8000) actually works. |
There was a problem hiding this comment.
The comment says the ping server is disabled via SKIP_PING_SERVER=1, but the code disables it for any non-empty value (os.Getenv(...) == ""). Either update the comment to match the behavior, or change the check to only skip when the env var is explicitly set (e.g., "1").
Suggested change
| // Optional ping server on :8050; disabled via SKIP_PING_SERVER=1 so that | |
| // CI can validate replaceWith port-mapping (8050→8000) actually works. | |
| // Optional ping server on :8050; disabled when SKIP_PING_SERVER is set | |
| // to any non-empty value (for example, SKIP_PING_SERVER=1) so that CI | |
| // can validate replaceWith port-mapping (8050→8000) actually works. |
Comment on lines
158
to
+203
| @@ -157,6 +190,21 @@ func httpMux() http.Handler { | |||
| return mux | |||
| } | |||
|
|
|||
| /* ----------------------------- PING :8050 ----------------------------- */ | |||
|
|
|||
| func pingMux() http.Handler { | |||
| mux := http.NewServeMux() | |||
|
|
|||
| mux.HandleFunc("/ping", func(w http.ResponseWriter, r *http.Request) { | |||
| writeJSON(w, http.StatusOK, map[string]any{ | |||
| "pong": true, | |||
| "from": "http", | |||
| }) | |||
| }) | |||
There was a problem hiding this comment.
/ping is implemented twice (once in httpMux and again in pingMux) with identical response bodies. To avoid accidental divergence (especially since this is used for port-mapping validation), consider extracting a shared handler function (or a small helper that writes the response) and reusing it in both muxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.