gdg charusat team 036 Fix: Add lazy loading to testimonial images in index.html#52
Open
Pratham3900 wants to merge 7 commits intokeploy:mainfrom
Open
gdg charusat team 036 Fix: Add lazy loading to testimonial images in index.html#52Pratham3900 wants to merge 7 commits intokeploy:mainfrom
Pratham3900 wants to merge 7 commits intokeploy:mainfrom
Conversation
Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
…atham3900/student-program into fix-lazy-loading-testimonials
Signed-off-by: pratham danawala <prathamdanawala@gmail.com>
Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
Signed-off-by: Pratham3900 <prathamdanawala@gmail.com>
|
Hi, I would like to work on this issue. Please assign it to me. |
Author
|
@amaan-bhati I COMPLETETED THIS ISSUE PLEASE REVIEW AND MERGE IT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDG CHARUSAT TEAM 036
Description
Fixed testimonial images in
index.htmlthat were loading eagerly on page load.Added native
loading="lazy"attribute to all testimonial<img>tags and updatedaltattributes for better accessibility.Fixes #51
Team ID: GDG CHARUSAT TEAM 036
Type of change
How Has This Been Tested?
index.htmlin the browser.Additional Context (Please include any Screenshots/gifs if relevant)
Before: