Skip to content

Conversation

@Sekhar-Kumar-Dash
Copy link
Contributor

Related Issue

Info about Issue or bug
Closes: keploy/keploy#354

added a unittest for wrappednodefetch function and added github actions

Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@re-Tick
Copy link
Contributor

re-Tick commented Mar 26, 2023

Please follow this convention for commit messages.

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash force-pushed the master branch 3 times, most recently from 14b046f to 5f0713b Compare March 27, 2023 18:24
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@re-Tick
Copy link
Contributor

re-Tick commented Mar 28, 2023

Hi @Sekhar-Kumar-Dash, can you close this PR and make other one with the correct commit convention. Because it is getting difficult to track your changes. Also the unit test logic is correct will have to run it whether it is working or not.

@Sekhar-Kumar-Dash
Copy link
Contributor Author

Related Issue

Info about Issue or bug Closes: keploy/keploy#354

added a unittest for wrappednodefetch function and added github actions

@re-Tick i raised a new pr please review it
#82

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash deleted the master branch March 29, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test]: add unit tests for octokit module

2 participants