Skip to content

Updated New Icons in Writers Program#35

Merged
Achanandhi-M merged 2 commits intokeploy:mainfrom
Srinu346:fix/update_old_icons
Oct 6, 2025
Merged

Updated New Icons in Writers Program#35
Achanandhi-M merged 2 commits intokeploy:mainfrom
Srinu346:fix/update_old_icons

Conversation

@Srinu346
Copy link
Copy Markdown
Contributor

Pull Request Template

Description

In this pr i have updated the social media icons in thw riters program page which were updated and updated the cdn link of font awesome. Updated icons [Slack , Youtube , LinkedIN , Twitter , Hashnode

Fixes # 3037

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran the files locally after changing the code and worked as expected .

Additional Context (Please include any Screenshots/gifs if relevant)

image image image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Copy link
Copy Markdown
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issue mentioned in the comment @Srinu346

Comment thread css/base.css Outdated
*
* ------------------------------------------------------------------- */
@import url("font-awesome/css/font-awesome.min.css");
@import url("https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to include the cdnjs here can you please update @Srinu346 ?

@Srinu346
Copy link
Copy Markdown
Contributor Author

hey shall i update that here
image

@Srinu346
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
@Srinu346 Srinu346 force-pushed the fix/update_old_icons branch from 5601a41 to 7ef5219 Compare September 25, 2025 12:07
Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
@Srinu346 Srinu346 force-pushed the fix/update_old_icons branch from 80b6599 to 757039b Compare September 25, 2025 13:06
@Srinu346 Srinu346 requested a review from Achanandhi-M October 4, 2025 10:13
Copy link
Copy Markdown
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread index.html
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Lato:wght@400&display=swap"/>
<link rel="stylesheet" href="css/base.css">
<link rel="stylesheet" href="css/vendor.css">
<link
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to do this without adding cdn?

@Achanandhi-M Achanandhi-M merged commit 7b3ec1b into keploy:main Oct 6, 2025
3 of 5 checks passed
whatsupsumit pushed a commit to whatsupsumit/writers-program that referenced this pull request Oct 7, 2025
* Updated New Icons and CDN link of font awesome

Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>

* fix: update old icons

Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>

---------

Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
Signed-off-by: Mr Sumo <sksumitboss123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants