feat: buckets B+C+D from jnremache field report#3
Merged
Conversation
Two not-a-ghax-bug patterns that burn anyone driving a real browser for the first time. Document them where a new contributor is already looking. - Chrome 113+ silently ignores --remote-debugging-port on the default user-data-dir. Fix: pass --user-data-dir=<path>. Edge is not affected. - Chrome/Edge launched with --remote-debugging-port sets navigator.webdriver = true, which trips Google anti-bot on sensitive pages (Business Profile verification, Drive sharing, Google Ads edits). Cheap mitigation: --disable-blink-features=AutomationControlled. For flows where that's not enough, detach / do the step manually / reattach. Full stealth-mode JS injection is explicitly out of scope. Bucket D of the 2026-04-20 jnremache field report.
Bucket B — architectural fixes (each a field-report issue): - ghax batch '<json>' (TOK-09) one-round-trip sequence executor. Parses inline JSON client-side, ships the whole plan in one RPC, and auto-re-snapshots between steps that reference @e<n> refs so the ref map always resolves against the current DOM. Directly fixes JNR-03 mid-sequence ref-shift on Material/React forms where comboboxes opening mid-plan reindex the ARIA tree. --no-auto-snapshot opts out. - snapshot is dialog-aware by default (JNR-06). When a modal is open ([role=dialog], [role=alertdialog], <dialog open>, [aria-modal=true]) the walker treats the top-most visible modal as the new root instead of inheriting aria-hidden="true" from the outer app. --no-dialog-scope opts out. - fill covers Angular + Material (JNR-04). React's native-setter + input pattern was already there; now the handler also dispatches blur (so Angular FormControl validators run) and handles contenteditable hosts (Material chip inputs, rich editors) via textContent + a proper InputEvent('insertText'). - state.rs::require_daemon gives actionable errors when state is stale (JNR-01). Probes 9222-9230 for a live ghax daemon and hints the port in the "no daemon state" error; pid-mismatch branch spells out `ghax detach && ghax attach` as the fix. Bucket C — papercut bundle: - ghax attach is silent on fresh success (TOK-07, POSIX). --verbose or GHAX_VERBOSE=1 restore the pid/port/browser line. "already attached" still prints — it's informational, not success. - ghax status surfaces active tab id + first 60 chars of title as a new `active` row (GHAX-FR-04). status --json gains activeTabId, activeTabTitle, activeTabUrl. - ghax eval auto-retries once past a nav-in-flight (GHAX-FR-01). The daemon waits up to 3s for the next load event and re-issues the evaluate — matches what a human would do with `wait --load && eval …`. Also applies to `text` (same root cause). - RPC client single-retries transient transport errors (JNR-02, connection refused/reset/timeout) after 50ms. Semantic errors (daemon answered with ok:false) are not retried. - --help splits the overloaded wait line into three forms (GHAX-FR-02); eval gains an inline note about the nav retry; attach lists --verbose. Smoke tests updated to cover the new status fields and the batch verb.
kepptic
added a commit
that referenced
this pull request
Apr 24, 2026
feat: buckets B+C+D from field report
kepptic
added a commit
that referenced
this pull request
Apr 24, 2026
feat: buckets B+C+D from field report
kepptic
added a commit
that referenced
this pull request
Apr 24, 2026
feat: buckets B+C+D from field report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the three remaining triage buckets from the 2026-04-20 jnremache field report.
Bucket B — architectural:
ghax batch '<json>'(TOK-09) — one-round-trip sequence executor with auto-re-snapshot between@e-using steps (naturally fixes JNR-03 mid-sequence ref-shift).fillcovers Angular blur + Material contenteditable (JNR-04).state.rserrors with live-port hint (JNR-01).Bucket C — papercuts:
attachon fresh success (+--verbose) (TOK-07)statussurfaces active tab id + title (GHAX-FR-04)evalauto-retries past nav-in-flight (GHAX-FR-01, also applies totext)waitline (GHAX-FR-02)Bucket D — docs: Known-browser-quirks section in
CONTRIBUTING.mdfor Chrome 113+ default-profile CDP restriction and Google anti-bot mitigation.Test plan
npm run typecheckcleannpm run buildcleancargo build --releasecleanactiveTabId/activeTabTitle/activeTabUrl) andbatchround-tripghax attach --verbose/ghax status/ghax batchall land as expected post-install-link