-
Notifications
You must be signed in to change notification settings - Fork 2.1k
highlights QAT in guide title #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @JyotinderSingh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the accuracy and clarity of the documentation for a Keras example by explicitly stating 'Quantization Aware Training' in its title and description. The changes ensure that users immediately understand the specific methodology employed in the Float8 Transformer model guide, improving the overall user experience and reducing potential ambiguity.
Highlights
- Documentation Clarity: Updated the titles and descriptions of the 'Float8 training and inference with a simple Transformer model' guide across its Python, Jupyter Notebook, and Markdown versions to explicitly include 'Quantization Aware Training' (QAT). This clarifies the specific quantization approach demonstrated in the example.
- Metadata Update: Synchronized the title of the Float8 Transformer guide within the
scripts/examples_master.py
file, which manages example metadata, to reflect the new, more precise QAT-inclusive title.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the titles and descriptions across multiple files to more accurately reflect that the example uses Quantization-Aware Training (QAT). The changes are consistent and improve clarity. I've suggested a minor stylistic improvement to hyphenate 'Quantization-Aware' in the titles for better readability and grammatical correctness.
examples/keras_recipes/float8_training_and_inference_with_transformer.py
Outdated
Show resolved
Hide resolved
examples/keras_recipes/ipynb/float8_training_and_inference_with_transformer.ipynb
Show resolved
Hide resolved
examples/keras_recipes/md/float8_training_and_inference_with_transformer.md
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.