-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add ESM API usage details to hub_master #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the hub_master.py
script to include configuration for generating API documentation for the new Evolutionary Scale Modeling (ESM) components within keras_hub
. This ensures that users can easily access detailed information about ESM tokenizers, backbone models, protein classifiers, and masked language models, along with their associated preprocessors.
Highlights
- Documentation Generation Configuration: Added a new top-level entry for "ESM" to the documentation generation configuration in
scripts/hub_master.py
. - ESM Tokenizer Documentation: Included
keras_hub.tokenizers.ESMTokenizer
and itsfrom_preset
method for API documentation generation. - ESM Backbone Model Documentation: Configured documentation generation for
keras_hub.models.ESMBackbone
, itsfrom_preset
method, and thetoken_embedding
property. - ESM Protein Classifier Documentation: Added
keras_hub.models.ESMProteinClassifier
, itsfrom_preset
method, andbackbone
/preprocessor
properties to the documentation generation. - ESM Protein Classifier Preprocessor Documentation: Included
keras_hub.models.ESMProteinClassifierPreprocessor
, itsfrom_preset
method, and thetokenizer
property. - ESM Masked PLM Model Documentation: Configured documentation generation for
keras_hub.models.ESMMaskedPLM
, itsfrom_preset
method, andbackbone
/preprocessor
properties. - ESM Masked PLM Preprocessor Documentation: Added
keras_hub.models.ESMMaskedPLMPreprocessor
, itsfrom_preset
method, and thetokenizer
property.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the API documentation configuration for the ESM model family to hub_master.py
. The changes look good overall, adding entries for the ESM tokenizer, backbone, protein classifier, and masked protein language model. I've pointed out a small inconsistency in the path
naming for the classifier and its preprocessor to align them with the project's conventions.
No description provided.