-
Notifications
You must be signed in to change notification settings - Fork 19.6k
numpy.meshgrid implementation #21292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21292 +/- ##
==========================================
- Coverage 82.57% 79.74% -2.84%
==========================================
Files 564 564
Lines 54677 54702 +25
Branches 8500 8508 +8
==========================================
- Hits 45152 43621 -1531
- Misses 7435 9053 +1618
+ Partials 2090 2028 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.ruff_cache | ||
keras_venv/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo this, this is very specific to your local setup
@@ -0,0 +1,3 @@ | |||
[pytest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file
@@ -59,14 +59,8 @@ def __init__(self, factor=0.5, data_format=None, seed=None, **kwargs): | |||
def get_random_transformation(self, images, training=True, seed=None): | |||
if seed is None: | |||
seed = self._get_seed_generator(self.backend._backend) | |||
# Base case: Unbatched data | |||
batch_size = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated, revert
@@ -78,37 +78,17 @@ def test_tf_data_compatibility(self): | |||
|
|||
def test_grayscale_with_single_color_image(self): | |||
test_cases = [ | |||
# batched inputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated, revert
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
please close this PR. It was implemented in #21600 |
issue: #30116
Follows the same pattern as other similar functions in the file
Passes all tests
I've removed the test from the excluded tests list, which allows for proper validation of the functionality.
@rkazants for review
All tests are passing