Skip to content

Conversation

sanleo-wq
Copy link
Contributor

issue: #30116

Follows the same pattern as other similar functions in the file
Passes all tests
I've removed the test from the excluded tests list, which allows for proper validation of the functionality.

@rkazants for review
All tests are passing

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.74%. Comparing base (dfaca0e) to head (2ddf04b).
⚠️ Report is 186 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21292      +/-   ##
==========================================
- Coverage   82.57%   79.74%   -2.84%     
==========================================
  Files         564      564              
  Lines       54677    54702      +25     
  Branches     8500     8508       +8     
==========================================
- Hits        45152    43621    -1531     
- Misses       7435     9053    +1618     
+ Partials     2090     2028      -62     
Flag Coverage Δ
keras 79.56% <0.00%> (-2.83%) ⬇️
keras-jax 63.58% <0.00%> (-0.04%) ⬇️
keras-numpy 58.71% <0.00%> (-0.04%) ⬇️
keras-openvino ?
keras-tensorflow 63.99% <0.00%> (-0.04%) ⬇️
keras-torch 63.64% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned requested a review from fchollet May 19, 2025 13:59
@gbaned gbaned added this to PR Queue May 19, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 19, 2025
.ruff_cache
keras_venv/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo this, this is very specific to your local setup

@@ -0,0 +1,3 @@
[pytest]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@@ -59,14 +59,8 @@ def __init__(self, factor=0.5, data_format=None, seed=None, **kwargs):
def get_random_transformation(self, images, training=True, seed=None):
if seed is None:
seed = self._get_seed_generator(self.backend._backend)
# Base case: Unbatched data
batch_size = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated, revert

@@ -78,37 +78,17 @@ def test_tf_data_compatibility(self):

def test_grayscale_with_single_color_image(self):
test_cases = [
# batched inputs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated, revert

Copy link

github-actions bot commented Sep 4, 2025

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Sep 4, 2025
@rkazants
Copy link
Contributor

please close this PR. It was implemented in #21600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Rejected
Development

Successfully merging this pull request may close these issues.

6 participants